[GUI] CoinControl Change #2859
Merged
[GUI] CoinControl Change #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liquid369
previously approved these changes
May 9, 2023
There was a problem hiding this comment.
tACK b05a3fa
Working as intended, the transaction below is for a custom change address.
https://zkbitcoin.com/tx/a4814fb9e12b8093e1fc854ddb222e5d113a0cefc9bab856769be5b10335d0e6
Disallows shielded change to be a transparent address
|
Needs a rebase due to header file inclusion ordering, but otherwise this is functionally sound |
panleone
force-pushed
the
qt_changeaddress
branch
from
b05a3fa
to
1ec227f
Compare
|
rebased on master |
Fuzzbawls
approved these changes
Jul 27, 2023
panleone
pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 10, 2024
* Automatically wake up select() when optimistic send was not used But only when we know that we are actually inside select() and that it currenlty is unlikely for it to have selected the node's socket for sending. We accept race conditions here as the select() timeout will ensure that we always send the data. * Don't manually call WakeSelect() in CSigSharesManager::SendMessages Not needed anymore * Disable optimistic send in PushMessage by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the functionality of CoinControl change by adding shield addresses.
In particular:
(NB: with transparent transaction I mean a transaction in which inputs are transparent and analogous definition for shield transaction)
In addition this PR fixes #2245